hi Poan chia_02: what happens if the specific node is nonexistent? Could you please add the case to the test plan?
chia_03: we have another KIP that exposes the versions through metrics. Could you please expand the rejected alternatives section regarding the option of “using metrics”? Best, Chia-Ping On 2025/07/23 13:57:08 PoAn Yang wrote: > Hi Chia-Ping, > > Thanks for the review. > > chia_00: Updated the comment of `DescribeFeaturesOptions#nodeId` function. > > chia_01: Updated the returned type of `DescribeFeaturesOptions#nodeId` to > `OptionalInt` and changed the default value as `OptionalInt.empty()`. > > Thanks, > PoAn > > > On Jul 23, 2025, at 2:35 AM, Chia-Ping Tsai <chia7...@apache.org> wrote: > > > > hi PoAn > > > > thanks for this KIP. Please take a look at following questions. > > > > chia_00: > > > > The behavior of "-1" defined by `DescribeFeaturesOptions#nodeId` is too > > detailed. That could obstructs us from tweaking the behavior in the future. > > Perhaps we could use "arbitrary controller/broker" instead. > > > > chia_01: > > > > the returned type of `DescribeFeaturesOptions#nodeId` could be replaced by > > `OptionalInt` > > > > Best, > > Chia-Ping > > > > On 2025/04/15 14:01:18 PoAn Yang wrote: > >> Hi all, > >> > >> I would like to start a discussion thread on KIP-1160. > >> > >> It adds node id to DescribeFeaturesOptions, so Admin client and > >> kafka-features > >> have ability to retrieve features from a specific node. > >> > >> Please take a look and feel free to share any thought. > >> > >> https://cwiki.apache.org/confluence/x/5gnXF > >> > >> Thanks, > >> PoAn > >
