Re: [PR] MINOR: Add 4.0.1 docs [kafka-site]

[via GitHub]

mimaison commented on code in PR #719:
URL: https://github.com/apache/kafka-site/pull/719#discussion_r2341814648


##########
40/documentation.html:
##########
@@ -30,7 +30,7 @@
     <!--#include virtual="toc.html" -->
   </div>
   <div class="right">
-    <!--#include virtual="../includes/_docs_banner.htm" -->
+    <!--//#include virtual="../includes/_docs_banner.htm" -->

Review Comment:
   We don't want this change. We need to show the docs banner on 4.0 as 4.1 is 
now the latest docs.



##########
40/generated/protocol_messages.html:
##########


Review Comment:
   I wasn't expected changes here but that looks correct. Not sure what 
happened with `protocol_messages.html` for 4.0 but it looks like it's currently 
wrong.



##########
40/streams/developer-guide/datatypes.html:
##########
@@ -103,7 +103,7 @@ <h3>Primitive and basic types<a class="headerlink" 
href="#primitive-and-basic-ty
         <pre class="line-numbers"><code class="language-xml">&lt;dependency&gt;
     &lt;groupId&gt;org.apache.kafka&lt;/groupId&gt;
     &lt;artifactId&gt;kafka-clients&lt;/artifactId&gt;
-    &lt;version&gt;{{fullDotVersion}}&lt;/version&gt;
+    &lt;version&gt;2.8.0&lt;/version&gt;

Review Comment:
   Why are we putting 2.8.0 here? I think we want `{{fullDotVersion}}` here



##########
40/streams/upgrade-guide.html:
##########
@@ -224,7 +224,7 @@ <h3><a id="streams_api_changes_400" 
href="#streams_api_changes_400">Streams API
 
     <p>
         In order to reduce storage overhead and improve API usability, a new 
method in the Java and Scala APIs that accepts a BiFunction for foreign key 
extraction is introduced by
-        <a href="https://cwiki.apache.org/confluence/x/gIuMEw";>KIP-1104</a>.
+        <a href="">KIP-1104</a>.

Review Comment:
   This change breaks the link



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org