Hi Tony,

Thanks for the KIP.

The motivation section has the following sentence: "We want to have
two different metrics for the broker's request handler versus the
controller's request handler to fix that issue:" This sentence and
everything after is not a motivation but your proposed changes. If you
agree, can you add a proposed changes section and move those sentences
to that section?

The Monitoring section has the following description for two of the metrics:
"Idle ratio for the broker request handler pool only (excludes controller)."
"Idle ratio for the controller request handler pool only (excludes broker)."

Kafka should only create and expose those metrics if the corresponding
request pool was created. For example, brokers should not create and
expose the ControllerRequestHandlerAvgIdlePercent metric. If you
agree, can you make that explicit in the KIP.

Thanks,
-- 
-José

Reply via email to