Hey Andrew, Thanks for the comment! The goal of this KIP is to check whether the transaction version supports epoch bumps at the end of each transaction. This feature is only supported in TV2 right now, not in TV0 / TV1.
Since future versions are unlikely to remove the epoch bump feature, I figured that it made sense to apply a stricter validation to all future versions >= TV2. That keeps the logic consistent and avoids reintroducing race conditions later. If a future version changes the behavior, we can handle that explicitly at that point. I can add a disclaimer in the code to double-check this part while introducing future versions. Let me know if that approach makes sense. On Wed, Oct 15, 2025 at 12:48 AM Andrew Schofield <[email protected]> wrote: > Hi Ritika, > Thanks for the KIP. I have one question. > > AS1: Does the new WriteTxnMarkers V1 request introduce support for > TV == 2 or TV >= 2? I only ask because the pseudo-code is quite loose > in the checking logic. I would have thought that V1 specifically introduces > TV == 2 and it would take another version bump for this RPC to support > higher transaction versions. > > Thanks, > Andrew > > > On 15 Oct 2025, at 02:28, Artem Livshits <[email protected]> > wrote: > > > > Hi Ritika, > > > > Thanks for the KIP! The proposal makes sense to me. > > > > I have one clarification question, in the rejected alternatives the first > > alternative says "However, its state is cleared after the first control > > record is written". Is this the control record or the first batch? > > > > -Artem > > > > On Tue, Oct 14, 2025 at 10:39 AM Ritika Reddy > <[email protected]> > > wrote: > > > >> Hi All, > >> I would like to start a discussion thread for KIP-1228. It's a > relatively > >> simple change and would really help strengthen EOS guarantees in Kafka. > >> KIP Link - > >> > >> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1228%3A+Add+Transaction+Version+to+WriteTxnMarkersRequest > >> JIRA - https://issues.apache.org/jira/browse/KAFKA-19446 > >> > >> Thanks, > >> Ritika > >> > >
