Hi Sushant, Thanks for the KIP. I tried replying previously but messed up so let's try again.
AS1: In the section of Proposed Changes, the KIP states that the acknowledge(ConsumerRecord, AcknowledgementType) method causes RPCs to be sent. This is incorrect. Only the poll and commit methods do this. AS2: For a situation in which the application is processing for an extended period, I would expect it to continue to call ShareConsumer.poll(Duration) repeatedly. This method returns a set of records to process. In the case where the application has renewed its acquisition locks, I would expect the renewed records to be returned from the next call to poll(Duration) as a way of confirming which records are still in the process of being delivered. AS3: We should specify the error handling where the application tries to renew but the broker does not support v2 of the updated RPCs. I think ShareConsumer.acknowledge() should throw an exception in this case. Thanks, Andrew ________________________________________ From: Sushant Mahajan <[email protected]> Sent: 07 October 2025 11:16 To: [email protected] <[email protected]> Subject: [DISCUSS] KIP-1222: Acquisition lock timeout renewal in share consumer explicit mode I’d like to start the discussion for KIP-1222: Acquisition lock timeout renewal in share consumer explicit mode. JIRA: https://issues.apache.org/jira/browse/KAFKA-19742 KIP Wiki: https://cwiki.apache.org/confluence/display/KAFKA/KIP-1222%3A+Acquisition+lock+timeout+renewal+in+share+consumer+explicit+mode Regards, Sushant Mahajan
