Thanks for the KIP! The private constructor approach would surely have been clearer to the users, but agree that it's out of our reach given the code structure we currently have. I would suggest we add a note to the KIP alternatives about the sealed approach Chia suggested, that surely would be 2nd best imo. We can't at the moment but will surely be a nice follow-up to this KIP whenever we get to j17.
+1 from me (binding) Thanks! Lianet On Thu, Oct 2, 2025 at 3:44 PM Paweł Szymczyk <[email protected]> wrote: > Hi guys > > We need two more binding votes. Could someone please look on that and > approve it? > > wt., 13 maj 2025 o 02:40 Matthias J. Sax <[email protected]> > napisał(a): > > > +1 (binding) > > > > -Matthias > > > > On 5/12/25 11:15 AM, Paweł Szymczyk wrote: > > > Hi David > > > > > > Sure I updated KIP with new terminology. > > > > > > > > > pt., 9 maj 2025 o 11:22 David Jacot <[email protected]> > > > napisał(a): > > > > > >> Hi Pawel, > > >> > > >> Thanks for the KIP and sorry for my late comment but I somehow missed > > the > > >> discussion thread about it. > > >> > > >> I have one minor ask: Could we change `generationId` to `memberEpoch` > in > > >> order to align with the KIP-848's new terminology? This is a good > > >> opportunity for doing it. > > >> > > >> Best, > > >> David > > >> > > >> On Fri, May 9, 2025 at 9:53 AM Paweł Szymczyk < > > [email protected]> > > >> wrote: > > >> > > >>> Hi all, > > >>> > > >>> I would like to start the voting thread for KIP-1136: Make > > >>> ConsumerGroupMetadata an interface. If you have additional comments > or > > >>> questions please use the discussion thread. > > >>> > > >>> KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-1136 > > >>> < > > >>> > > >> > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1136%3A+Make+ConsumerGroupMetadata+an+interface > > >>>> > > >>> > > >>> -- > > >>> Best regards > > >>> Paweł Szymczyk > > >>> > > >> > > > > > > > > > > > > -- > Pozdrawiam > Paweł Szymczyk >
