chia7712 commented on PR #748:
URL: https://github.com/apache/kafka-site/pull/748#issuecomment-3571947215

   > Anyway, just an idea, not sure if it's worth doing?
   
   That is good idea to me. To avoid introducing major changes to 3.9, let's 
focus on using JDK 25 just to run tests. We could implement this by creating a 
specific test task that uses the JDK 25 toolchain
   
   for example:
   ```
       task test21(type: Test, dependsOn: compileJava) {
           maxParallelForks = maxTestForks
           ignoreFailures = userIgnoreFailures
   
           maxHeapSize = defaultMaxHeapSize
           jvmArgs = defaultJvmArgs
   
           javaLauncher = javaToolchains.launcherFor {
               languageVersion = JavaLanguageVersion.of(25)
           }
   
           testLogging {
               events = userTestLoggingEvents ?: testLoggingEvents
               showStandardStreams = userShowStandardStreams ?: 
testShowStandardStreams
               exceptionFormat = testExceptionFormat
               displayGranularity = 0
           }
           logTestStdout.rehydrate(delegate, owner, this)()
   
           exclude testsToExclude
   
           useJUnitPlatform {
               includeEngines 'junit-jupiter'
           }
   
           retry {
               maxRetries = userMaxTestRetries
               maxFailures = userMaxTestRetryFailures
           }
   
           testClassesDirs = sourceSets.test.output.classesDirs
           classpath = sourceSets.test.runtimeClasspath
       }
   ```
   
   > Maybe it would be worth looking at that for trunk too, it could enable 
Kafka to upgrade the JDK faster in the future, even before Gradle gains 
support? It might also make branch switching easier, if Gradle were configured 
to download a JDK instead of running with the one that happens to be installed 
locally?
   
   I suggest keeping this solution specific to 3.9 for now, unless faster JDK 
updates become a priority on trunk


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to