Hi Mickael, That’s a solid point. I realise there are others like me who have been accessing the RecordHeader class directly (https://github.com/spring-projects/spring-kafka/blob/813b9af333a6b812617e970f34ca0ae447dda7fb/spring-kafka/src/main/java/org/springframework/kafka/listener/KafkaMessageListenerContainer.java#L2812) by virtue of it being public and well documented.
I don’t want to break the precedence and make RecordHeader part of the public API at this point, but I like your idea of adding addXXX-like methods to Headers.java. This way the KIP adds new methods to both RecordHeader(s) and Header(s) with the helper methods. I’ve updated the KIP to reflect this. Best, Aditya On 2026/04/02 14:56:36 Mickael Maison wrote: > Hi, > > Thanks for the KIP. I'm a bit confused because RecordHeader is not > part of the public API. It's in > org.apache.kafka.common.header.internals. > To create a Header, users have to create their own Header > implementation, or more likely use Headers.add(String key, byte[] > value). > > So either this would require making RecordHeader part of the public > API, or an alternative is to add Headers.add() overloads that take > common types as the 2nd argument. > > Thanks, > Mickael > > On Wed, Apr 1, 2026 at 7:05 PM Andrew Schofield <[email protected]> wrote: > > > > Hi > > Thanks for the KIPs. You're writing them faster than the community can read > > them :) > > > > I'll take a proper look soon. > > > > Thanks, > > Andrew > > > > On 2026/04/01 15:35:47 Aditya Kousik wrote: > > > Hi all, > > > > > > I'd like to start a discussion on KIP-1308: Extend RecordHeader API for > > > Common Value Types. > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1308%3A+Extend+RecordHeader+API+for+Common+Value+Types > > > > > > Putting a string or int into a RecordHeader today requires manual byte > > > encoding; reading it back requires the same in reverse. This KIP adds > > > static factories (RecordHeader.ofString, ofInt, etc.) and corresponding > > > typed accessors, with no wire format changes. > > > > > > Looking forward to your feedback. > > > > > > Thanks, > > > Aditya Kousik > > > >
