Owen-CH-Leung commented on code in PR #849:
URL: https://github.com/apache/kafka-site/pull/849#discussion_r3154674278
##########
.github/workflows/build-and-deploy.yml:
##########
@@ -51,7 +51,7 @@ jobs:
GITHUB_CONTEXT: ${{ toJson(github) }}
- name: Configure
id: configure
- run: echo "ref=${{ inputs.deploy-to-asf-site && 'asf-site' ||
'asf-staging' }}" >> "$GITHUB_OUTPUT"
+ run: echo "ref=${{ (github.event_name == 'push' ||
inputs.deploy-to-asf-site) && 'asf-site' || 'asf-staging' }}" >>
"$GITHUB_OUTPUT"
Review Comment:
>
I think this is a good idea. I have added a new step to the deploy job that
posts a comment on the merged PR once staging is updated. It only fires on
push-triggered runs (not manual dispatches) and silently skips if there's no
associated PR. The comment links to the staging site and notes the Mon/Thu
promotion schedule.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
