Hi, During the code review of KIP-1306, we’ve identified that the new methods in ConsumerRebalanceListener can be confusing for adopters because the 1-arg methods onPartitionsAssigned and onPartitionsRevoked are abstract - forcing an empty implementation. Making these methods default with an empty body helps avoid this situation. I’ve updated the KIP to reflect this change.
Please take a look to let me know if there are any concerns with this approach. Thanks, Aditya Kousik > On May 8, 2026, at 07:09, Aditya Kousik <[email protected]> wrote: > > Hi all, > > The KIP is accepted with 3 binding votes from Lianet, Andrew, and Omnia. > > Best, > Aditya > >> On 2026/05/08 13:29:47 Omnia Ibrahim wrote: >> +1 (binding) >> Thanks Aditya for the KIP! >> >>>> On 17 Apr 2026, at 12:26, Aditya Kousik <[email protected]> wrote: >>> >>> Hi everyone, >>> >>> I'd like to start a vote on KIP-1306: Extend ConsumerRebalanceListener with >>> Consumer-aware methods. Popular frameworks rework the rebalance listener by >>> passing the full consumer reference into callback methods to support >>> bookkeeping ops like commit, seek. This KIP introduces 3 new default >>> methods in ConsumerRebalanceListener to achieve this. It deprecates >>> existing subscribe() methods on Consumer that take a rebalance listener arg >>> and introduces a new setConsumerRebalanceListener method going forward. >>> >>> KIP: https://cwiki.apache.org/confluence/x/9ZU8G >>> Discussion thread: >>> https://lists.apache.org/thread/8nmybx73f0tmjlb56sdophvoy4yomlx2 >>> >>> Thanks, >>> Aditya Kousik >> >>
