Shekhar Prasad Rajak created KAFKA-20690:
--------------------------------------------
Summary: PersisterStateBatchCombinerTest silently skips 23 of 24
cases
Key: KAFKA-20690
URL: https://issues.apache.org/jira/browse/KAFKA-20690
Project: Kafka
Issue Type: Bug
Reporter: Shekhar Prasad Rajak
ersisterStateBatchCombinerTest wraps every @ParameterizedTest body in if
(test.shouldRun) { ... }, and shouldRun defaults to false. Only 1 of 24
parameter cases asserts; the other 23 return without invoking assertEquals, CI
reports them as PASSED even when the expected value is wrong.
The PersisterStateBatchCombiner hot path also makes a few avoidable
allocations: a LinkedList per getMergeCandidatePair call, and
compareBatchDeliveryInfo recomputed twice per merge step.
We must:
Remove the shouldRun gate; all cases must assert.
Correct the wrong expected value uncovered by enabling the cases.
Add a stress-test class for correctness on large inputs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)