TengYao Chi created KAFKA-20717:
-----------------------------------
Summary: Add KIP-1331 broker-side observability sensors
(plugin.setTopology / plugin.getTopology)
Key: KAFKA-20717
URL: https://issues.apache.org/jira/browse/KAFKA-20717
Project: Kafka
Issue Type: Sub-task
Reporter: TengYao Chi
Assignee: TengYao Chi
KIP-1331 specifies eight broker-side sensors under
kafka.server:type=group-coordinator-metrics. This ticket covers the two pairs
that remain unimplemented after KAFKA-20696:
- streams-group-topology-description-set-\{success,error}-\{rate,count}
- streams-group-topology-description-get-\{success,error}-\{rate,count}
For reference, the cleanup-\{cycle,eligible} and delete-\{success,error}
sensors landed in KAFKA-20696.
set-\{success,error}. plugin.setTopology already ships in trunk via
StreamsGroupTopologyDescriptionManager.invokeSetTopology (added by
KAFKA-20623 split 2 / #22552). The KIP-1331 sensor observability for that
path was deferred and never landed. Add sensor recording at the outcome
branches inside invokeSetTopology:
- SUCCESS branch -> set-success
- PERMANENT branch (including the synchronous-throw and null-cause
branches that fold into permanent) -> set-error
- TRANSIENT branch -> set-error
get-\{success,error}. plugin.getTopology is added by KAFKA-20624's
describe-path wiring (StreamsGroupTopologyDescriptionManager.
attachTopologyDescriptions). Sensor recording lives in that same building
block. This ticket depends on KAFKA-20624 landing the get-path call site;
the simplest sequencing is to land KAFKA-20624 first and then add the
get-success / get-error records here, or land them together in one PR if
the reviewer prefers a single "complete KIP-1331 broker-side observability"
change.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
