hi all I noticed an issue regarding the "protected" modifier with this new annotation. https://github.com/apache/kafka/pull/21337#discussion_r3574009798
TL;DR: The "protected" modifier seems to be treated as part of the "public" scope for now, so we can't use it to hide [internal details] from users and we need to maintain backward compatibility? There is another PR (https://github.com/apache/kafka/pull/20598) using the same approach (like CloseOptions), so I'd like to check the best practices for @InterfaceAudience.Public before merging it. Best, Chia-Ping On 2026/01/05 04:21:10 Ashwin via dev wrote: > Hello folks, > > Reviving this old thread > https://lists.apache.org/thread/ly5ddkobr1wc07gvhwc1p0jg94qg8cxc to discuss > KIP-1265. > > Apache Kafka lacks a concrete, centralized definition of what constitutes a > public API. The most relevant information currently available is found here: > > Kafka Improvement Proposals#Whatisconsidereda%22majorchange%22thatneedsaKIP > <https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals#KafkaImprovementProposals-Whatisconsidereda%22majorchange%22thatneedsaKIP> > > Without formal definition or guardrails, there is a risk that builders may > inadvertently import internal classes leading to possible build breakages > when they compile against a newer Kafka version > > > Please let me know your thoughts for > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1265%3A+Public+API+needs+to+be+explicitly+declared > > Cheers, > Ashwin >
