-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25944/
-----------------------------------------------------------
(Updated Sept. 27, 2014, 1:52 a.m.)
Review request for kafka.
Bugs: KAFKA-1013
https://issues.apache.org/jira/browse/KAFKA-1013
Repository: kafka
Description (updated)
-------
OffsetCLient Tool API. ImportZkOffsets and ExportZkOffsets replaced by
ImportOffsets and ExportOffsets
Modified the comments in the headers
Corrected a value
Refactored code
Removed the commented code
Closed channel connections
Closed sockets
Removed the persistent offsetManager channel
Diffs (updated)
-----
config/consumer.properties 83847de30d10b6e78bb8de28e0bb925d7c0e6ca2
core/src/main/scala/kafka/client/ClientUtils.scala
ebba87f0566684c796c26cb76c64b4640a5ccfde
core/src/main/scala/kafka/consumer/SimpleConsumer.scala
d349a3000feb9ccd57d1f3cb163548d5bf432186
core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala
fbc680fde21b02f11285a4f4b442987356abd17b
core/src/main/scala/kafka/javaapi/consumer/SimpleConsumer.scala
0ab0195dc9f66f407061d0fac2549bd6291e41ff
core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala
d1e7c434e77859d746b8dc68dd5d5a3740425e79
core/src/main/scala/kafka/tools/ExportOffsets.scala PRE-CREATION
core/src/main/scala/kafka/tools/ImportOffsets.scala PRE-CREATION
core/src/main/scala/kafka/tools/OffsetClient.scala PRE-CREATION
core/src/main/scala/kafka/tools/OffsetClientConfig.scala PRE-CREATION
core/src/main/scala/kafka/utils/Utils.scala
29d5a17d4a03cfd3f3cdd2994cbd783a4be2732e
core/src/test/scala/other/kafka/TestOffsetManager.scala
41f334d48897b3027ed54c58bbf4811487d3b191
core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala
2d9325045ac1ac2d7531161b32c98c847125cbf0
Diff: https://reviews.apache.org/r/25944/diff/
Testing
-------
Thanks,
Mayuresh Gharat