Hi all, Reviving this thread to note a follow-up change that landed on trunk for 4.4.0. Details in KAFKA-20939.
During review of the initial KIP-909 implementation it became clear that shipping the async-bootstrap model as the default silently changed the error surface for every client upgrader in a way that is not source-compatible: existing code that catches KafkaException (wrapping ConfigException) at construction time no longer catches the failure, which now arrives later as BootstrapResolutionException from send() / poll() / etc., is permanently attached to the client, and requires a close-and-recreate cycle to recover. To avoid this silent break on upgrade, the default of bootstrap.resolve.timeout.ms was changed from 120000 (2 minutes) to 0. * 0 (default) — synchronous DNS resolution in the constructor, same error semantics as pre-KIP-909. This is what users get after upgrading to 4.4.0 without changing anything. * > 0 — opt in to the async model as originally described by the KIP; failures surface as BootstrapResolutionException as designed. The valid range was widened from atLeast(1) to atLeast(0) to accommodate this. Nothing else about the KIP has changed — the config name, the exception type, and the async behavior when opted in are all as originally voted on. I'll update the KIP wiki page shortly to reflect the new default and add a note in the "Compatibility & Migration" section explaining that the async model is now strictly opt-in. The 4.4.0 upgrade notes also documents this. Thanks, TengYao On 2023/04/25 19:51:51 Philip Nee wrote: > Thanks for the vote. We've decided to make a minor change to the default > timeout from 5min to 2min. > > On Tue, Apr 25, 2023 at 11:42 AM David Jacot <[email protected]> wrote: > > > +1 (binding) Thanks for the KIP, Philip! > > > > Le mar. 25 avr. 2023 à 20:23, José Armando García Sancio > > <[email protected]> a écrit : > > > > > +1. Thanks for the design. Looking forward to the implementation. > > > > > > On Tue, Apr 25, 2023 at 10:49 AM Jason Gustafson > > > <[email protected]> wrote: > > > > > > > > +1 Thanks Philip! > > > > > > > > > > > > On Thu, Apr 13, 2023 at 7:49 AM Kirk True <[email protected]> wrote: > > > > > > > > > +1 (non-binding) > > > > > > > > > > > On Apr 10, 2023, at 1:53 PM, Philip Nee <[email protected]> > > wrote: > > > > > > > > > > > > Hey everyone! > > > > > > > > > > > > I'm starting a vote for KIP-909: DNS Resolution Fallures Should Not > > > Fail > > > > > > the Client <http://DNS Resolution Failure Should Not Fail the > > > Clients> > > > > > > > > > > > > Please refer to the discussion thread here: > > > > > > https://lists.apache.org/thread/st84zzwnq5m3pkzd1r7jk9lmqdt9m98s > > > > > > > > > > > > Thanks! > > > > > > P > > > > > > > > > > > > > > > > > > > > > > -- > > > -José > > > > > >
