[
https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14151947#comment-14151947
]
Joel Koshy commented on KAFKA-1499:
-----------------------------------
Yes I understand that the LogConfig is at the topic level. The broker-side
compression-type is also intuitive as a topic-level config. The remaining
problem is that we need to somehow pass in a config to indicate whether
broker-side compression is enabled at all or not. That makes sense as a broker
config, and I think it makes sense to pass it in to LogManager (either via its
default logconfig or explicit constructor parameter), and I think it also makes
sense to allow passing that to the Log class via a constructor parameter
(because the Log class contains implementation details of how messages are
appended which is where compression if any happens). I'm not sure whether we
should allow it to be passed into to Log via the LogConfig which is why if we
allow it we will need to "filter" that out in LogConfig.validateNames
The earlier patch did not include broker.compression.enable but we felt it
would lead to confusing results - this is described in the earlier review
comments. (See follow-up comments to Neha's initial review).
> Broker-side compression configuration
> -------------------------------------
>
> Key: KAFKA-1499
> URL: https://issues.apache.org/jira/browse/KAFKA-1499
> Project: Kafka
> Issue Type: New Feature
> Reporter: Joel Koshy
> Assignee: Manikumar Reddy
> Labels: newbie++
> Fix For: 0.8.2
>
> Attachments: KAFKA-1499.patch, KAFKA-1499.patch,
> KAFKA-1499_2014-08-15_14:20:27.patch, KAFKA-1499_2014-08-21_21:44:27.patch,
> KAFKA-1499_2014-09-21_15:57:23.patch, KAFKA-1499_2014-09-23_14:45:38.patch,
> KAFKA-1499_2014-09-24_14:20:33.patch, KAFKA-1499_2014-09-24_14:24:54.patch,
> KAFKA-1499_2014-09-25_11:05:57.patch
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> A given topic can have messages in mixed compression codecs. i.e., it can
> also have a mix of uncompressed/compressed messages.
> It will be useful to support a broker-side configuration to recompress
> messages to a specific compression codec. i.e., all messages (for all
> topics) on the broker will be compressed to this codec. We could have
> per-topic overrides as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
