Chia-Ping Tsai created KAFKA-21218:
--------------------------------------

             Summary: TopicCommandTest should leverage topicService.createTopic
                 Key: KAFKA-21218
                 URL: https://issues.apache.org/jira/browse/KAFKA-21218
             Project: Kafka
          Issue Type: Improvement
            Reporter: Chia-Ping Tsai
            Assignee: Chia-Ping Tsai


{{topicService.createTopic}} is the helper of {{{}TopicCommand{}}}, but the 
test {{TopicCommandTest}} prefers to use {{{}ClusterInstance#createTopic{}}}, 
which is a bit odd and *reduces* the test coverage.

We should revisit *the* following test cases:
 # {{testCreate}}
 # {{testCreateWithDefaults}}
 # {{testCreateWithDefaultReplication}}
 # {{testCreateWithDefaultPartitions}}
 # {{testCreateWithConfigs}}
 # {{testCreateWithReplicaAssignment}}
 # {{testCreateAlterTopicWithRackAware}}

 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to