Chia-Ping Tsai created KAFKA-21572:
--------------------------------------

             Summary: CordonedLogDirectoryCount and LogDirectoryCordoned aren't 
removed when closing LogManger
                 Key: KAFKA-21572
                 URL: https://issues.apache.org/jira/browse/KAFKA-21572
             Project: Kafka
          Issue Type: Bug
            Reporter: Chia-Ping Tsai
            Assignee: Chia-Ping Tsai


 
{code:java}
        metricsGroup.newGauge("OfflineLogDirectoryCount", () -> 
offlineLogDirs().size());
        metricsGroup.newGauge("CordonedLogDirectoryCount", () -> 
cordonedLogDirs().size());
        for (File dir : logDirs) {
            metricsGroup.newGauge("LogDirectoryOffline",
                    () -> liveLogDirs.contains(dir) ? 0 : 1,
                    Map.of("logDirectory", dir.getAbsolutePath()));
            metricsGroup.newGauge("LogDirectoryCordoned",
                    () -> cordonedLogDirs.contains(dir.getAbsolutePath()) ? 1 : 
0,
                    Map.of("logDirectory", dir.getAbsolutePath()));
        }
{code}
 

 
{code:java}
        metricsGroup.removeMetric("OfflineLogDirectoryCount");
        for (File dir : logDirs) {
            metricsGroup.removeMetric("LogDirectoryOffline", 
Map.of("logDirectory", dir.getAbsolutePath()));
        }
{code}
We create them in the constructor, but we forget to remove them on shutdown.

 



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

Reply via email to