> On Oct. 5, 2014, 11:35 p.m., Jun Rao wrote: > > core/src/test/scala/unit/kafka/log/LogTest.scala, lines 113-129 > > <https://reviews.apache.org/r/26346/diff/2/?file=713903#file713903line113> > > > > Appending 2GB of data in a unit test is probably too long. We can > > probably just manually validate the fix and skip the unit test.
The concern I have with manual validation only is that over time with enough of these bugs, we don't any coverage for regression testing. Any chance this can at least be a system test? - Neha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26346/#review55479 ----------------------------------------------------------- On Oct. 6, 2014, 4:48 p.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26346/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2014, 4:48 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1670 > https://issues.apache.org/jira/browse/KAFKA-1670 > > > Repository: kafka > > > Description > ------- > > KAFKA-1670. Corrupt log files for segment.bytes values close to Int.MaxInt. > > > Diffs > ----- > > core/src/main/scala/kafka/log/Log.scala > 0ddf97bd30311b6039e19abade41d2fbbad2f59b > > Diff: https://reviews.apache.org/r/26346/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
