> On Oct. 8, 2014, 2:04 a.m., Joel Koshy wrote:
> > clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java, line
> > 271
> > <https://reviews.apache.org/r/25886/diff/8/?file=714236#file714236line271>
> >
> > Where is this used?
Used in ProducerConfig line 180:
.define(ACKS_CONFIG,
Type.STRING,
"1",
in(Arrays.asList("all","-1", "0", "1")),
Importance.HIGH,
ACKS_DOC)
ACKS are defined as a String and not a Short. I don't want to change a public
API, and there are discussions of turning it into an enum anyway, so validating
the input against a list of strings seems appropriate.
- Gwen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25886/#review55745
-----------------------------------------------------------
On Oct. 8, 2014, 1:46 a.m., Gwen Shapira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25886/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2014, 1:46 a.m.)
>
>
> Review request for kafka.
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1555: provide strong consistency with reasonable availability
>
>
> Diffs
> -----
>
> clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
> f9de4af
> clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java addc906
>
> clients/src/main/java/org/apache/kafka/common/errors/NotEnoughReplicasAfterAppendException.java
> PRE-CREATION
>
> clients/src/main/java/org/apache/kafka/common/errors/NotEnoughReplicasException.java
> PRE-CREATION
> clients/src/main/java/org/apache/kafka/common/protocol/Errors.java d434f42
> core/src/main/scala/kafka/cluster/Partition.scala ff106b4
> core/src/main/scala/kafka/common/ErrorMapping.scala 3fae791
>
> core/src/main/scala/kafka/common/NotEnoughReplicasAfterAppendException.scala
> PRE-CREATION
> core/src/main/scala/kafka/common/NotEnoughReplicasException.scala
> PRE-CREATION
> core/src/main/scala/kafka/log/LogConfig.scala 5746ad4
> core/src/main/scala/kafka/producer/SyncProducerConfig.scala 69b2d0c
> core/src/main/scala/kafka/server/KafkaApis.scala c584b55
> core/src/main/scala/kafka/server/KafkaConfig.scala 165c816
> core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala
> 39f777b
> core/src/test/scala/unit/kafka/producer/ProducerTest.scala dd71d81
> core/src/test/scala/unit/kafka/producer/SyncProducerTest.scala 24deea0
> core/src/test/scala/unit/kafka/utils/TestUtils.scala 2dbdd3c
>
> Diff: https://reviews.apache.org/r/25886/diff/
>
>
> Testing
> -------
>
> With 3 broker cluster, created 3 topics each with 1 partition and 3 replicas,
> with 1,3 and 4 min.insync.replicas.
> * min.insync.replicas=1 behaved normally (all writes succeeded as long as a
> broker was up)
> * min.insync.replicas=3 returned NotEnoughReplicas when required.acks=-1 and
> one broker was down
> * min.insync.replicas=4 returned NotEnoughReplicas when required.acks=-1
>
> See notes about retry behavior in the JIRA.
>
>
> Thanks,
>
> Gwen Shapira
>
>
