[ https://issues.apache.org/jira/browse/KAFKA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14168696#comment-14168696 ]
Jun Rao commented on KAFKA-1634: -------------------------------- Joel, I don't see OffsetFetchResponse contain timestamp (it only contains offset, metadata and error code). I agree that it's better to move retentionMs to the topic-level of OffsetCommitRequest. We can bump up the protocol version if needed. > Improve semantics of timestamp in OffsetCommitRequests and update > documentation > ------------------------------------------------------------------------------- > > Key: KAFKA-1634 > URL: https://issues.apache.org/jira/browse/KAFKA-1634 > Project: Kafka > Issue Type: Bug > Reporter: Neha Narkhede > Assignee: Joel Koshy > Priority: Blocker > Fix For: 0.8.2 > > > From the mailing list - > following up on this -- I think the online API docs for OffsetCommitRequest > still incorrectly refer to client-side timestamps: > https://cwiki.apache.org/confluence/display/KAFKA/A+Guide+To+The+Kafka+Protocol#AGuideToTheKafkaProtocol-OffsetCommitRequest > Wasn't that removed and now always handled server-side now? Would one of > the devs mind updating the API spec wiki? -- This message was sent by Atlassian JIRA (v6.3.4#6332)