[
https://issues.apache.org/jira/browse/KAFKA-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14170071#comment-14170071
]
Jun Rao commented on KAFKA-1493:
--------------------------------
James,
Thanks for the patch. A couple of more questions.
1. The following header frame used in the patch doesn't seem to match exactly
what's described in
http://fastcompression.blogspot.com/2013/04/lz4-streaming-format-final.html.
So, we are inventing our own header? Is that ok?
/*
* Message format:
* HEADER which consists of:
* 1) magic byte sequence (8 bytes)
* 2) compression method token (1 byte)
* 3) compressed length (4 bytes)
* 4) original message length (4 bytes)
* and compressed message itself
* Block size: 64 Kb
* */
2. If the io stream code in this patch is identical to that in lz4-java, could
we just use lz4-java instead?
Thanks,
> Use a well-documented LZ4 compression format and remove redundant LZ4HC option
> ------------------------------------------------------------------------------
>
> Key: KAFKA-1493
> URL: https://issues.apache.org/jira/browse/KAFKA-1493
> Project: Kafka
> Issue Type: Improvement
> Affects Versions: 0.8.2
> Reporter: James Oliver
> Assignee: Ivan Lyutov
> Priority: Blocker
> Fix For: 0.8.2
>
> Attachments: KAFKA-1493.patch, KAFKA-1493.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
