[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14170275#comment-14170275
]
Jun Rao commented on KAFKA-1481:
--------------------------------
Vladimir,
Thanks for the patch. My suggestion is actually slightly different from what
you did. Instead of using
"kafka.consumer":type="ConsumerTopicMetrics",name="clientId=af_servers,AllTopics,BytesPerSec"
I was suggesting
"kafka.consumer":type="ConsumerTopicMetrics",clientId="af_servers",topic="AllTopics",name="BytesPerSec"
This is probably the more standard mbean name.
We can do that by using the following method to create MetricName and pass in
the mBeanName that we want.
public MetricName(String group, String type, String name, String scope,
String mBeanName).
We also need to extend KafkaMetricsGroup by adding new helper functions that
take a MetricName explicitly.
def newMeter(name: MetricName, eventType: String, timeUnit: TimeUnit)
Also, your patch doesn't seem to apply to latest trunk.
git apply ~/Downloads/KAFKA-1481_2014-10-13_18-23-35.patch
error: core/src/main/scala/kafka/common/ClientIdTopic.scala: No such file or
directory
> Stop using dashes AND underscores as separators in MBean names
> --------------------------------------------------------------
>
> Key: KAFKA-1481
> URL: https://issues.apache.org/jira/browse/KAFKA-1481
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.8.1.1
> Reporter: Otis Gospodnetic
> Priority: Critical
> Labels: patch
> Fix For: 0.8.2
>
> Attachments: KAFKA-1481_2014-06-06_13-06-35.patch,
> KAFKA-1481_2014-10-13_18-23-35.patch
>
>
> MBeans should not use dashes or underscores as separators because these
> characters are allowed in hostnames, topics, group and consumer IDs, etc.,
> and these are embedded in MBeans names making it impossible to parse out
> individual bits from MBeans.
> Perhaps a pipe character should be used to avoid the conflict.
> This looks like a major blocker because it means nobody can write Kafka 0.8.x
> monitoring tools unless they are doing it for themselves AND do not use
> dashes AND do not use underscores.
> See: http://search-hadoop.com/m/4TaT4lonIW
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
