-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26663/#review56490
-----------------------------------------------------------
Looks good. Just one minor comment. Could you get rid of this build warning?
/Users/nnarkhed/Projects/kafka/core/src/main/scala/kafka/log/LogConfig.scala:103:
object Math is deprecated: use the scala.math package object instead.
(Example package object usage: scala.math.Pi )
if (segmentJitterMs == 0) 0 else scala.util.Random.nextLong() %
Math.min(segmentJitterMs, segmentMs)
- Neha Narkhede
On Oct. 13, 2014, 11:16 p.m., Ewen Cheslack-Postava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26663/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2014, 11:16 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-979
> https://issues.apache.org/jira/browse/KAFKA-979
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-979 Add optional random jitter for time based log rolling.
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/log/Log.scala
> a123cdc52f341a802b3e4bfeb29a6154332e5f73
> core/src/main/scala/kafka/log/LogCleaner.scala
> c20de4ad4734c0bd83c5954fdb29464a27b91dff
> core/src/main/scala/kafka/log/LogConfig.scala
> d2cc9e3d6b7a4fd24516d164eb3673e6ce052129
> core/src/main/scala/kafka/log/LogSegment.scala
> 7597d309f37a0b3756381f9500100ef763d466ba
> core/src/main/scala/kafka/server/KafkaConfig.scala
> 7fcbc16da898623b03659c803e2a20c7d1bd1011
> core/src/main/scala/kafka/server/KafkaServer.scala
> 3e9e91f2b456bbdeb3055d571e18ffea8675b4bf
> core/src/test/scala/unit/kafka/log/LogSegmentTest.scala
> 7b97e6a80753a770ac094e101c653193dec67e68
> core/src/test/scala/unit/kafka/log/LogTest.scala
> a0cbd3bbbeeabae12caa6b41aec31a8f5dfd034b
>
> Diff: https://reviews.apache.org/r/26663/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ewen Cheslack-Postava
>
>
