[
https://issues.apache.org/jira/browse/KAFKA-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182138#comment-14182138
]
Jun Rao commented on KAFKA-1675:
--------------------------------
Thanks for the patch. Looks good. It doesn't seem to apply any more. Could you
rebase?
> bootstrapping tidy-up
> ---------------------
>
> Key: KAFKA-1675
> URL: https://issues.apache.org/jira/browse/KAFKA-1675
> Project: Kafka
> Issue Type: Bug
> Reporter: Szczepan Faber
> Assignee: Ivan Lyutov
> Fix For: 0.8.3
>
> Attachments: KAFKA-1675.patch
>
>
> I'd like to suggest following changes:
> 1. remove the 'gradlew' and 'gradlew.bat' scripts from the source tree. Those
> scripts don't work, e.g. they fail with exception when invoked. I just got a
> user report where those scripts were invoked by the user and it led to an
> exception that was not easy to grasp. Bootstrapping step will generate those
> files anyway.
> 2. move the 'gradleVersion' extra property from the 'build.gradle' into
> 'gradle.properties'. Otherwise it is hard to automate the bootstrapping
> process - in order to find out the gradle version, I need to evaluate the
> build script, and for that I need gradle with correct version (kind of a
> vicious circle). Project properties declared in the gradle.properties file
> can be accessed exactly the same as the 'ext' properties, for example:
> 'project.gradleVersion'.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
