[
https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14198637#comment-14198637
]
Dmytro Kostiuchenko commented on KAFKA-1667:
--------------------------------------------
As suggested on mailing list, moving discussion to JIRA.
Currently I have an initial patch, which seems to work. I would like to know,
whether overall code is ok. Also there are few TODOs in the
code
# I haven't added documentation to the properties, as {{ConfigDef}} suggests.
Should I?
# I'm not sure what Importance should be assigned to properties. It is
{{MEDIUM}} for all properties. Where can I find some info on this?
# Not totally sure, that validations are correct. Tried to figure that out from
the code, still might miss something.
Please, find the patch attached.
Thanks
> topic-level configuration not validated
> ----------------------------------------
>
> Key: KAFKA-1667
> URL: https://issues.apache.org/jira/browse/KAFKA-1667
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.8.1.1
> Reporter: Ryan Berdeen
> Labels: newbie
> Attachments: KAFKA-1667.patch
>
>
> I was able to set the configuration for a topic to these invalid values:
> {code}
> Topic:topic-config-test PartitionCount:1 ReplicationFactor:2
> Configs:min.cleanable.dirty.ratio=-30.2,segment.bytes=-1,retention.ms=-12,cleanup.policy=lol
> {code}
> It seems that the values are saved as long as they are the correct type, but
> are not validated like the corresponding broker-level properties.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
