[
https://issues.apache.org/jira/browse/KAFKA-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14213021#comment-14213021
]
Ewen Cheslack-Postava commented on KAFKA-1748:
----------------------------------------------
A couple of improvements to the patch:
1. Minor fix for parsing vagrant ssh-config output to make it skip extraneous
log lines.
2. Update the system_test/README with instructions for configuring the tests.
3. Clean out host information from cluster_config.json files. This touches a
bunch of files, but the changes are trivial (and help ensure the tests are
actually getting hostnames from the right place).
There's one other place where localhost appears in config files -- some of them
have a "zookeeper" setting that looks like it's supposed to tell the
producer/consumer its in how to connect to ZK. As far as I can tell, these
aren't actually used anywhere and removing it from one of the test configs
didn't seem to have any effect. However, since I can't even figure out how it
was used in the commit that actually introduced the setting, I'm a bit hesitant
to remove these as well. Maybe someone from LI can check if they modify these
settings in their setup, which would indicate they might actually be doing
something?
> Decouple system test cluster resources definition from service definitions
> --------------------------------------------------------------------------
>
> Key: KAFKA-1748
> URL: https://issues.apache.org/jira/browse/KAFKA-1748
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.8.1.1
> Reporter: Ewen Cheslack-Postava
> Assignee: Ewen Cheslack-Postava
> Attachments: KAFKA-1748.patch, KAFKA-1748_2014-11-03_12:04:18.patch,
> KAFKA-1748_2014-11-14_14:54:17.patch
>
>
> Currently the system tests use JSON files that specify the set of services
> for each test and where they should run (i.e. hostname). These currently
> assume that you already have SSH keys setup, use the same username on the
> host running the tests and the test cluster, don't require any additional
> ssh/scp/rsync flags, and assume you'll always have a fixed set of compute
> resources (or that you'll spend a lot of time editing config files).
> While we don't want a whole cluster resource manager in the system tests, a
> bit more flexibility would make it easier to, e.g., run tests against a local
> vagrant cluster or on dynamically allocated EC2 instances. We can separate
> out the basic resource spec (i.e. json specifying how to access machines)
> from the service definition (i.e. a broker should run with settings x, y, z).
> Restricting to a very simple set of mappings (i.e. map services to hosts with
> round robin, optionally restricting to no reuse of hosts) should keep things
> simple.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
