> On Nov. 19, 2014, 12:01 a.m., Jun Rao wrote: > > core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala, lines > > 166-169 > > <https://reviews.apache.org/r/28025/diff/4/?file=766675#file766675line166> > > > > Should this be added to the ConsumerConnector interface? > > > > Another issue with this api is that a rebalance can happen immediately > > after a ConsumerConnector is instantiated. By that time, the listener may > > not be set and the consumer will miss a rebalance event. So, ideally, we > > need to add in ConsumerConnector a new set of createStreams apis that take > > the listener .
The rebalance will happen only after createMessageStreams is called - which is why I was suggesting earlier that we allow setting this only once _before_ the call to createMessageStreams. - Joel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28025/#review62058 ----------------------------------------------------------- On Nov. 18, 2014, 1:42 a.m., Jiangjie Qin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28025/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2014, 1:42 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-345 > https://issues.apache.org/jira/browse/KAFKA-345 > > > Repository: kafka > > > Description > ------- > > Added new unit test. > > > Incorporated Joel's comments > > > Incorporated Joel's comments > > > Addressed Joel's comments. > > > Diffs > ----- > > core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala > f476973eeff653473a60c3ecf36e870e386536bc > core/src/main/scala/kafka/javaapi/consumer/ConsumerRebalanceListener.java > PRE-CREATION > core/src/main/scala/kafka/javaapi/consumer/ZookeeperConsumerConnector.scala > 1f98db5d692adc113189ec8c75a4fad29d6b6ffe > > core/src/test/scala/unit/kafka/consumer/ZookeeperConsumerConnectorTest.scala > e1d87112a2a587aa3a2f5875f278b276c32f45ac > > Diff: https://reviews.apache.org/r/28025/diff/ > > > Testing > ------- > > > Thanks, > > Jiangjie Qin > >
