[
https://issues.apache.org/jira/browse/KAFKA-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14228655#comment-14228655
]
BalajiSeshadri commented on KAFKA-328:
--------------------------------------
Updated reviewboard https://reviews.apache.org/r/27818/diff/
against branch origin/trunk
> Write unit test for kafka server startup and shutdown API
> ----------------------------------------------------------
>
> Key: KAFKA-328
> URL: https://issues.apache.org/jira/browse/KAFKA-328
> Project: Kafka
> Issue Type: Bug
> Reporter: Neha Narkhede
> Assignee: BalajiSeshadri
> Labels: newbie
> Attachments: KAFKA-328-FORMATTED.patch,
> KAFKA-328-REVIEW-COMMENTS.patch, KAFKA-328.patch, KAFKA-328.patch,
> KAFKA-328_2014-11-10_11:05:58.patch, KAFKA-328_2014-11-29_00:08:05.patch
>
>
> Background discussion in KAFKA-320
> People often try to embed KafkaServer in an application that ends up calling
> startup() and shutdown() repeatedly and sometimes in odd ways. To ensure this
> works correctly we have to be very careful about cleaning up resources. This
> is a good practice for making unit tests reliable anyway.
> A good first step would be to add some unit tests on startup and shutdown to
> cover various cases:
> 1. A Kafka server can startup if it is not already starting up, if it is not
> currently being shutdown, or if it hasn't been already started
> 2. A Kafka server can shutdown if it is not already shutting down, if it is
> not currently starting up, or if it hasn't been already shutdown.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
