[ https://issues.apache.org/jira/browse/KAFKA-1796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14233842#comment-14233842 ]
Guozhang Wang commented on KAFKA-1796: -------------------------------------- Dave, The tool you mentioned seems just to validate if JSON is valid, while in this JIRA we are actually trying to check the semantics of the JSON for partition tools. Neha, Yes the fix should be in partition reassignment tool. Which JIRA are you referring to? > Sanity check partition command line tools > ----------------------------------------- > > Key: KAFKA-1796 > URL: https://issues.apache.org/jira/browse/KAFKA-1796 > Project: Kafka > Issue Type: Bug > Reporter: Guozhang Wang > Labels: newbie > Fix For: 0.8.3 > > > We need to sanity check the input json has the valid values before triggering > the admin process. For example, we have seen a scenario where the json input > for partition reassignment tools have partition replica info as {broker-1, > broker-1, broker-2} and it is still accepted in ZK and eventually lead to > under replicated count, etc. This is partially because we use a Map rather > than a Set reading the json input for this case; but in general we need to > make sure the input parameters like Json needs to be valid before writing it > to ZK. -- This message was sent by Atlassian JIRA (v6.3.4#6332)