> On Dec. 10, 2014, 3:21 p.m., Gwen Shapira wrote: > > Non-binding LGTM from me. > > > > Any chance of cleaning up the whitespace? makes the change looks way bigger > > than it really is. > > > > Few suggested improvements below:
My mistake - the whitespaces were in the code originally and this patch cleans them up. Sorry and thanks for the cleanup :) - Gwen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28859/#review64546 ----------------------------------------------------------- On Dec. 9, 2014, 6:11 p.m., Jeff Holoman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28859/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2014, 6:11 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1812 > https://issues.apache.org/jira/browse/KAFKA-1812 > > > Repository: kafka > > > Description > ------- > > KAFKA-1812 initial > > > Diffs > ----- > > core/src/main/scala/kafka/utils/Utils.scala > 58685cc47b4c43e4ee68b73f1ee34eb99a5aa547 > core/src/test/scala/unit/kafka/utils/UtilsTest.scala > 0d0f0e2fba367180eeb718a259e8d680a73c3a73 > > Diff: https://reviews.apache.org/r/28859/diff/ > > > Testing > ------- > > > Thanks, > > Jeff Holoman > >
