-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29379/
-----------------------------------------------------------

(Updated Dec. 23, 2014, 8:44 p.m.)


Review request for kafka.


Changes
-------

KAFKA-1788: Adding configuration for batch.expiration.ms to ensure batches for 
partitions that has no leader do not stay in accumulator forever.


Bugs: KAFKA-1788
    https://issues.apache.org/jira/browse/KAFKA-1788


Repository: kafka


Description
-------

KAFKA-1788: Adding configuration for batch.expiration.ms to ensure batches for 
partitions that has no leader do not stay in accumulator forever.


Diffs
-----

  clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java 
f61efb35db7e0de590556e6a94a7b5cb850cdae9 
  clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java 
a893d88c2f4e21509b6c70d6817b4b2cdd0fd657 
  
clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java
 c15485d1af304ef53691d478f113f332fe67af77 
  
clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordBatch.java
 dd0af8aee98abed5d4a0dc50989e37888bb353fe 
  
clients/src/test/java/org/apache/kafka/clients/producer/RecordAccumulatorTest.java
 2c9932401d573549c40f16fda8c4e3e11309cb85 
  clients/src/test/java/org/apache/kafka/clients/producer/SenderTest.java 
ef2ca65cabe97b909f17b62027a1bb06827e88fe 

Diff: https://reviews.apache.org/r/29379/diff/


Testing (updated)
-------

Unit test added. 


Thanks,

Parth Brahmbhatt

Reply via email to