-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29029/#review66134
-----------------------------------------------------------

Ship it!


Non-binding +1 - the fix and test look good.

- Gwen Shapira


On Dec. 24, 2014, 2:47 a.m., Jeff Holoman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29029/
> -----------------------------------------------------------
> 
> (Updated Dec. 24, 2014, 2:47 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1512
>     https://issues.apache.org/jira/browse/KAFKA-1512
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-1512 wire in Override configuration
> 
> KAFKA-1512 wire in overrides
> 
> KAFKA-1512 test mods
> 
> KAFKA-1512 IP Overrides
> 
> 
> KAFKA-1512 IP Overrides
> 
> 
> Merge branch 'trunk' of https://github.com/apache/kafka into 1512-updates
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/network/SocketServer.scala 
> e451592fe358158548117f47a80e807007dd8b98 
>   core/src/main/scala/kafka/server/KafkaServer.scala 
> 1bf7d10cef23a77e716666eb16bf6d0e68bc4ebe 
>   core/src/test/scala/unit/kafka/network/SocketServerTest.scala 
> 5f4d85254c384dcc27a5a84f0836ea225d3a901a 
> 
> Diff: https://reviews.apache.org/r/29029/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jeff Holoman
> 
>

Reply via email to