Dana Powers created KAFKA-1841:
----------------------------------
Summary: OffsetCommitRequest API - timestamp field is not versioned
Key: KAFKA-1841
URL: https://issues.apache.org/jira/browse/KAFKA-1841
Project: Kafka
Issue Type: Bug
Components: core
Affects Versions: 0.8.2
Environment: wire-protocol
Reporter: Dana Powers
Priority: Blocker
Timestamp field was added to the OffsetCommitRequest wire protocol api for
0.8.2 by KAFKA-1012 . The 0.8.1.1 server does not support the timestamp field,
so I think the api version of OffsetCommitRequest should be incremented and
checked by the 0.8.2 kafka server before attempting to read a timestamp from
the network buffer in OffsetCommitRequest.readFrom
(core/src/main/scala/kafka/api/OffsetCommitRequest.scala)
It looks like a subsequent patch (kafka-1462) added another api change to
support a new constructor w/ params generationId and consumerId, calling that
version 1, and a pending patch (kafka-1634) adds retentionMs as another field,
while possibly removing timestamp altogether, calling this version 2. So the
fix here is not straightforward enough for me to submit a patch.
This could possibly be merged into KAFKA-1634, but opening as a separate Issue
because I believe the lack of versioning in the current trunk should block
0.8.2 release.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
