[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14269585#comment-14269585
]
Manikumar Reddy commented on KAFKA-1723:
----------------------------------------
1. Added MetricName object and related changes. This patch introduces changes
to producer interface.
2. Sensor object still has name as unique key . To make name unique, still the
code encodes topic name+ name , node name + name into the name string. Because
it is internal code, i have not changed. If required, we can use MetricName
object for Sensor name also.
3. Currently producer client.id (ProducerConfig.CLIENT_ID_CONFIG) is not
mandatory.
Can we make this mandatory? or Can we auto-generate this (producer-1,2), if
not supplied ?
client.id is required to make unique MBean name. if multiple producers
(without client.id) are running on same JVM, then we will miss some MBeans.
> make the metrics name in new producer more standard
> ---------------------------------------------------
>
> Key: KAFKA-1723
> URL: https://issues.apache.org/jira/browse/KAFKA-1723
> Project: Kafka
> Issue Type: Sub-task
> Components: clients
> Affects Versions: 0.8.2
> Reporter: Jun Rao
> Assignee: Manikumar Reddy
> Priority: Blocker
> Fix For: 0.8.2
>
> Attachments: KAFKA-1723.patch, KAFKA-1723_2015-01-08_21:41:13.patch,
> KAFKA-1723_2015-01-08_22:02:22.patch
>
>
> The jmx name in the new producer looks like the following:
> kafka.producer.myclientid:type=mytopic
> However, this can be ambiguous since we allow "." in client id and topic.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
