----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29751/#review67499 -----------------------------------------------------------
core/src/main/scala/kafka/server/KafkaApis.scala <https://reviews.apache.org/r/29751/#comment111536> You could just change getOffsets so it doesn't have this behavior instead of checking the condition here. It looks like this is the only place it's called from so nothing else should be relying on that behavior and it just simplifies the getOffsets code. - Ewen Cheslack-Postava On Jan. 9, 2015, 2:53 a.m., Jun Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29751/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2015, 2:53 a.m.) > > > Review request for kafka. > > > Bugs: kafka-1851 > https://issues.apache.org/jira/browse/kafka-1851 > > > Repository: kafka > > > Description > ------- > > fix the behavior of OffsetFetchRequest on unknown partition > > > Diffs > ----- > > core/src/main/scala/kafka/server/KafkaApis.scala > 2f009920af37de3cf0a3eb131f2124f4e532c4e4 > core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala > 8c5364fa97da1be09973c176d1baeb339455d319 > > Diff: https://reviews.apache.org/r/29751/diff/ > > > Testing > ------- > > > Thanks, > > Jun Rao > >
