[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14275651#comment-14275651
]
Manikumar Reddy edited comment on KAFKA-1723 at 1/13/15 6:22 PM:
-----------------------------------------------------------------
While going through metrics related issues, i came across KAFKA-517. KAFKA-517
is related to usage of special characters( comma, equals, colon, quote,
asterisk, or question mark) in JMX MBean name. Some user supplied fields
(hostname. etc..) can contain these special chars.
We have not given support for special characters in kafka metrics code. JMX
best practices link suggests to quote the value field of key/value pair. I want
to implement this change. MBean names with-out quotes and with quotes are
different.
Ex:
kafka.producer:type=producer-metrics,client-id="my-producer",topic-id="my-topic"
Though this not a problem for current producer related metrics (We are using
only one user supplied value : topic name.).
This may be required for new consumer metrics.
If Ok, i will submit follow-up patch.
Also , Can i submit patch for KAFKA-517?. This means change in existing
brokers,consumer, old producers MBean names.
anyhow MBean names got changed in 0.8.2 (KAFKA-1481).
Reference
http://www.oracle.com/technetwork/java/javase/tech/best-practices-jsp-136021.html#mozTocId434075
was (Author: omkreddy):
While going through metrics related issues, i came across KAFKA-517. KAFKA-517
is related to usage of special characters( comma, equals, colon, quote,
asterisk, or question mark) in JMX MBean name. Some user supplied fields can
contain these
special chars (hostname. etc..)
We have not given support for special characters in kafka metrics code. JMX
best practices link suggests to quote the value field of key/value pair. I want
to implement this change. MBean names with-out quotes and with quotes are
different.
Ex:
kafka.producer:type=producer-metrics,client-id="my-producer",topic-id="my-topic"
Though this not a problem for current producer related metrics (We are using
only one user supplied value : topic name.).
This may be required for new consumer metrics.
If Ok, i will submit follow-up patch.
Also , Can i submit patch for KAFKA-517?. This means change in existing
brokers,consumer, old producers MBean names.
anyhow MBean names got changed in 0.8.2 (KAFKA-1481).
Reference
http://www.oracle.com/technetwork/java/javase/tech/best-practices-jsp-136021.html#mozTocId434075
> make the metrics name in new producer more standard
> ---------------------------------------------------
>
> Key: KAFKA-1723
> URL: https://issues.apache.org/jira/browse/KAFKA-1723
> Project: Kafka
> Issue Type: Sub-task
> Components: clients
> Affects Versions: 0.8.2
> Reporter: Jun Rao
> Assignee: Manikumar Reddy
> Priority: Blocker
> Fix For: 0.8.2
>
> Attachments: KAFKA-1723.patch, KAFKA-1723_2015-01-08_21:41:13.patch,
> KAFKA-1723_2015-01-08_22:02:22.patch, KAFKA-1723_2015-01-09_14:24:18.patch,
> KAFKA-1723_2015-01-09_23:43:22.patch
>
>
> The jmx name in the new producer looks like the following:
> kafka.producer.myclientid:type=mytopic
> However, this can be ambiguous since we allow "." in client id and topic.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
