-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29210/#review68107
-----------------------------------------------------------
A couple of minor comments. Neither of these is a blocker for 0.8.2. So we just
need to patch trunk.
I saw the following unit test failure. Could we reduce the amount of data used
in writeDups()?
kafka.admin.DeleteTopicTest > testDeleteTopicWithCleaner FAILED
java.lang.OutOfMemoryError: Java heap space
at java.nio.HeapByteBuffer.<init>(HeapByteBuffer.java:39)
at java.nio.ByteBuffer.allocate(ByteBuffer.java:312)
at kafka.log.SkimpyOffsetMap.<init>(OffsetMap.scala:42)
at kafka.log.LogCleaner$CleanerThread.<init>(LogCleaner.scala:177)
at kafka.log.LogCleaner$$anonfun$1.apply(LogCleaner.scala:86)
at kafka.log.LogCleaner$$anonfun$1.apply(LogCleaner.scala:86)
at
scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244)
at
scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244)
at scala.collection.immutable.Range.foreach(Range.scala:141)
at scala.collection.TraversableLike$class.map(TraversableLike.scala:244)
at scala.collection.AbstractTraversable.map(Traversable.scala:105)
at kafka.log.LogCleaner.<init>(LogCleaner.scala:86)
at kafka.log.LogManager.<init>(LogManager.scala:64)
at kafka.server.KafkaServer.createLogManager(KafkaServer.scala:344)
at kafka.server.KafkaServer.startup(KafkaServer.scala:89)
at kafka.utils.TestUtils$.createServer(TestUtils.scala:134)
at
kafka.admin.DeleteTopicTest$$anonfun$10.apply(DeleteTopicTest.scala:272)
at
kafka.admin.DeleteTopicTest$$anonfun$10.apply(DeleteTopicTest.scala:272)
at
scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244)
at
scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244)
at scala.collection.immutable.List.foreach(List.scala:318)
at scala.collection.TraversableLike$class.map(TraversableLike.scala:244)
at scala.collection.AbstractTraversable.map(Traversable.scala:105)
at
kafka.admin.DeleteTopicTest.createTestTopicAndCluster(DeleteTopicTest.scala:272)
at
kafka.admin.DeleteTopicTest.testDeleteTopicWithCleaner(DeleteTopicTest.scala:241)
core/src/main/scala/kafka/log/LogManager.scala
<https://reviews.apache.org/r/29210/#comment112274>
Instead of making it public, would it be better to expose a awaitCleaned()
method?
- Jun Rao
On Jan. 13, 2015, 1:01 a.m., Gwen Shapira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29210/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2015, 1:01 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1819
> https://issues.apache.org/jira/browse/KAFKA-1819
>
>
> Repository: kafka
>
>
> Description
> -------
>
> added locking
>
>
> improved tests per Joel and Neha's suggestions
>
>
> added cleaner test to DeleteTopicTest
>
>
> Fixes to DeleteTopicTest: clean up servers after cleaner test and move
> cleaner verification to the validation function
>
>
> minor fixes suggested by Joel
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/log/LogCleaner.scala
> f8fcb843c80eec3cf3c931df6bb472c019305253
> core/src/main/scala/kafka/log/LogCleanerManager.scala
> bcfef77ed53f94017c06a884e4db14531774a0a2
> core/src/main/scala/kafka/log/LogManager.scala
> 4ebaae00ca4b80bf15c7930bae2011d98bbec053
> core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala
> 29cc01bcef9cacd8dec1f5d662644fc6fe4994bc
> core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala
> 5bfa764638e92f217d0ff7108ec8f53193c22978
>
> Diff: https://reviews.apache.org/r/29210/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gwen Shapira
>
>
