> On Jan. 13, 2015, 5:36 a.m., Neha Narkhede wrote: > > To make review easier, could you add the output of the command for all > > options for 2 consumer groups that consume 2 or more topics to the JIRA? It > > will make it easier to review. One thing to watch out for is the ease of > > scripting the output from this tool. I'd also suggest asking Clark/Tood or > > one of the SREs to review the output from the tool.
I just attached the output from a run through all the commands and options on the JIRA. I excluded the noise coming from SLF4J that I was getting on every command. - Onur ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29831/#review67789 ----------------------------------------------------------- On Jan. 15, 2015, 10:30 p.m., Onur Karaman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29831/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2015, 10:30 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1476 > https://issues.apache.org/jira/browse/KAFKA-1476 > > > Repository: kafka > > > Description > ------- > > Merged in work for KAFKA-1476 and sub-task KAFKA-1826 > > > Diffs > ----- > > bin/kafka-consumer-groups.sh PRE-CREATION > core/src/main/scala/kafka/admin/AdminUtils.scala > 28b12c7b89a56c113b665fbde1b95f873f8624a3 > core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala PRE-CREATION > core/src/main/scala/kafka/utils/ZkUtils.scala > c14bd455b6642f5e6eb254670bef9f57ae41d6cb > core/src/test/scala/unit/kafka/admin/DeleteConsumerGroupTest.scala > PRE-CREATION > core/src/test/scala/unit/kafka/utils/TestUtils.scala > ac15d34425795d5be20c51b01fa1108bdcd66583 > > Diff: https://reviews.apache.org/r/29831/diff/ > > > Testing > ------- > > > Thanks, > > Onur Karaman > >