> On Jan. 19, 2015, 4:14 p.m., Jun Rao wrote: > > core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala, > > lines 310-320 > > <https://reviews.apache.org/r/30026/diff/1/?file=824938#file824938line310> > > > > It seems it's simpler to just change the defaultOffsetPartition in the > > broker config to 1. The test will run faster that way. > > Jaikiran Pai wrote: > That sounds good too. I don't yet have enough knowledge of the code to be > sure it wouldn't introduce other issues, so went with this very isolated > change. I'll update this patch (and run the test) with the change you > suggest. Thanks Jun Rao!
Patch updated and ran the tests a few times with this change and it passed. - Jaikiran ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30026/#review68620 ----------------------------------------------------------- On Jan. 19, 2015, 4:33 p.m., Jaikiran Pai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30026/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2015, 4:33 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1878 > https://issues.apache.org/jira/browse/KAFKA-1878 > > > Repository: kafka > > > Description > ------- > > KAFKA-1878 Set a smaller value for the number of partitions for the offset > commit topic in the test, to prevent timeouts while fetching metadata for the > topic > > > Diffs > ----- > > core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala > 420a1dd30264c72704cc383a4161034c7922177d > > Diff: https://reviews.apache.org/r/30026/diff/ > > > Testing > ------- > > > Thanks, > > Jaikiran Pai > >
