> On 一月 23, 2015, 3:14 a.m., Joe Stein wrote: > > Can you add test cases for the failure please? We should be able to apply > > the test cases, run test, see the failure, apply fix, verify the success. > > Thanks!
It was actually a pretty silly mistake I made. Mirror maker will always have NPE thrown out when starting up. After apply the patch it won't occur again. - Jiangjie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30199/#review69337 ----------------------------------------------------------- On 一月 23, 2015, 3:57 a.m., Jiangjie Qin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30199/ > ----------------------------------------------------------- > > (Updated 一月 23, 2015, 3:57 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1890 > https://issues.apache.org/jira/browse/KAFKA-1890 > > > Repository: kafka > > > Description > ------- > > Patch for KAFKA-1890 > Mirror maker hit NPE at startup. > > > Diffs > ----- > > core/src/main/scala/kafka/tools/MirrorMaker.scala > 5cbc8103e33a0a234d158c048e5314e841da6249 > > Diff: https://reviews.apache.org/r/30199/diff/ > > > Testing > ------- > > > Thanks, > > Jiangjie Qin > >
