> On Feb. 2, 2015, 5:42 p.m., Neha Narkhede wrote: > > Onur, we should be able to check in after these review comments are > > addressed. Also, how would deleting offsets for a group work when the > > offset storage is Kafka? It's fine to not address it in this patch. Can you > > please create a JIRA to handle that?
Clark brought up some suggestions on the tool: - describe currently just shows the log end offset. It might also be useful to show the log start offset. - describe should ideally compare results (current offset, lag, and maybe ownership) using both kafka and zookeeper side-by-side. If we were to follow through with these suggestions, should they be applied in a later patch? As for kafka offset storage: I think that's out of the scope of this patch. I made a separate jira for that: https://issues.apache.org/jira/browse/KAFKA-1921 - Onur ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29831/#review70581 ----------------------------------------------------------- On Feb. 4, 2015, 11:41 p.m., Onur Karaman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29831/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2015, 11:41 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1476 > https://issues.apache.org/jira/browse/KAFKA-1476 > > > Repository: kafka > > > Description > ------- > > Merged in work for KAFKA-1476 and sub-task KAFKA-1826 > > > Diffs > ----- > > bin/kafka-consumer-groups.sh PRE-CREATION > core/src/main/scala/kafka/admin/AdminUtils.scala > 28b12c7b89a56c113b665fbde1b95f873f8624a3 > core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala PRE-CREATION > core/src/main/scala/kafka/utils/ZkUtils.scala > c14bd455b6642f5e6eb254670bef9f57ae41d6cb > core/src/test/scala/unit/kafka/admin/DeleteConsumerGroupTest.scala > PRE-CREATION > core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala > 33c27678bf8ae8feebcbcdaa4b90a1963157b4a5 > core/src/test/scala/unit/kafka/utils/TestUtils.scala > 54755e8dd3f23ced313067566cd4ea867f8a496e > > Diff: https://reviews.apache.org/r/29831/diff/ > > > Testing > ------- > > > Thanks, > > Onur Karaman > >
