----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30810/#review71837 -----------------------------------------------------------
core/src/main/scala/kafka/tools/MirrorMaker.scala <https://reviews.apache.org/r/30810/#comment117705> The node itself may not be inserted into the list yet, so the current implementation of remove could throw an NPE - Joel Koshy On Feb. 9, 2015, 11:58 p.m., Jiangjie Qin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30810/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2015, 11:58 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1937 > https://issues.apache.org/jira/browse/KAFKA-1937 > > > Repository: kafka > > > Description > ------- > > Fix for KAFKA-1937 > > > Diffs > ----- > > core/src/main/scala/kafka/tools/MirrorMaker.scala > 5374280dc97dc8e01e9b3ba61fd036dc13ae48cb > > Diff: https://reviews.apache.org/r/30810/diff/ > > > Testing > ------- > > > Thanks, > > Jiangjie Qin > >
