[
https://issues.apache.org/jira/browse/KAFKA-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14316759#comment-14316759
]
Jay Kreps commented on KAFKA-1926:
----------------------------------
At a high level this looks good. The main thrust of the ticket had actually
been to clean up the class Utils.scala and migrate a lot of that to Utils.java,
but this mostly actually cleans up other utils packages which is also good and
needed.
A few minor comments:
1. The time constants should probably move into Time.java as static final
variables, right?
2. If Time moves we may need to move Scheduler, KafkaScheduler, and
MockScheduler as they are intertwined.
3. SystemTime.java should probably deprecate SystemTime.scala, right?
4. Time.scala should be deleted?
> Replace kafka.utils.Utils with o.a.k.common.utils.Utils
> -------------------------------------------------------
>
> Key: KAFKA-1926
> URL: https://issues.apache.org/jira/browse/KAFKA-1926
> Project: Kafka
> Issue Type: Improvement
> Affects Versions: 0.8.2.0
> Reporter: Jay Kreps
> Labels: newbie, patch
> Attachments: KAFKA-1926.patch
>
>
> There is currently a lot of duplication between the Utils class in common and
> the one in core.
> Our plan has been to deprecate duplicate code in the server and replace it
> with the new common code.
> As such we should evaluate each method in the scala Utils and do one of the
> following:
> 1. Migrate it to o.a.k.common.utils.Utils if it is a sensible general purpose
> utility in active use that is not Kafka-specific. If we migrate it we should
> really think about the API and make sure there is some test coverage. A few
> things in there are kind of funky and we shouldn't just blindly copy them
> over.
> 2. Create a new class ServerUtils or ScalaUtils in kafka.utils that will hold
> any utilities that really need to make use of Scala features to be convenient.
> 3. Delete it if it is not used, or has a bad api.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
