----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29468/#review72032 -----------------------------------------------------------
Can you add unit tests? - Gwen Shapira On Feb. 11, 2015, 10:34 p.m., Parth Brahmbhatt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29468/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2015, 10:34 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1805, KAFKA-1905 and KAFKA-42 > https://issues.apache.org/jira/browse/KAFKA-1805 > https://issues.apache.org/jira/browse/KAFKA-1905 > https://issues.apache.org/jira/browse/KAFKA-42 > > > Repository: kafka > > > Description > ------- > > Merge remote-tracking branch 'origin/trunk' into KAFKA-1805 > > > Handling the case where al the fields in ProducerRecord can be null. > > > Adding toString back. > > > Diffs > ----- > > clients/src/main/java/org/apache/kafka/clients/producer/ProducerRecord.java > 065d4e6c6a4966ac216e98696782e2714044df29 > > Diff: https://reviews.apache.org/r/29468/diff/ > > > Testing > ------- > > > Thanks, > > Parth Brahmbhatt > >
