> On Feb. 12, 2015, 2:31 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/server/ReplicaManager.scala, line 271 > > <https://reviews.apache.org/r/29647/diff/6/?file=861625#file861625line271> > > > > This is good, but maybe call this canRespondNow ? Since before > > replication won't apply if there are no errors in the partition appends or > > if there is no data.
In fact flipping the condition and calling the helper function delayedRequestRequired may be even clearer - Joel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29647/#review72156 ----------------------------------------------------------- On Feb. 12, 2015, 7:14 a.m., Gwen Shapira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29647/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2015, 7:14 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1697 > https://issues.apache.org/jira/browse/KAFKA-1697 > > > Repository: kafka > > > Description > ------- > > added early handling of invalid number of acks to handler and a test > > > merging with current trunk > > > moved check for legal requiredAcks to append and fixed the tests accordingly > > > changing exception back to retriable > > > cleaning unused exceptions > > > refactored appendToLog for clarity > > > Diffs > ----- > > > clients/src/main/java/org/apache/kafka/common/errors/InvalidRequiredAcksException.java > PRE-CREATION > > clients/src/main/java/org/apache/kafka/common/errors/NotEnoughReplicasAfterAppendException.java > a6107b818947d6d6818c85cdffcb2b13f69a55c0 > clients/src/main/java/org/apache/kafka/common/protocol/Errors.java > a8deac4ce5149129d0a6f44c0526af9d55649a36 > core/src/main/scala/kafka/cluster/Partition.scala > e6ad8be5e33b6fb31c078ad78f8de709869ddc04 > core/src/main/scala/kafka/server/KafkaApis.scala > 6ee7d8819a9ef923f3a65c865a0a3d8ded8845f0 > core/src/main/scala/kafka/server/ReplicaManager.scala > fb948b9ab28c516e81dab14dcbe211dcd99842b6 > core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala > a1f72f8c2042ff2a43af503b2e06f84706dad9db > core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala > faa907131ed0aa94a7eacb78c1ffb576062be87a > > Diff: https://reviews.apache.org/r/29647/diff/ > > > Testing > ------- > > > Thanks, > > Gwen Shapira > >
