> On Feb. 14, 2015, 9:04 p.m., Gwen Shapira wrote: > > core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala, lines 83-85 > > <https://reviews.apache.org/r/31021/diff/1/?file=863672#file863672line83> > > > > Adding comma-separated columns at the end of the row, instead of > > parentheses, will make it easier for those who try to parse the output for > > monitoring. > > > > Not sure how many people are doing this, though.
Good point :) I got some exception when I ran the offset checker a couple of days ago and there are someone on the mailing list confused by the offset checker as well. So I guess there probably a few people are using the offset checker. Considering this is also a tool in 0.8.2, I think it might worth making it work properly. - Jiangjie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31021/#review72514 ----------------------------------------------------------- On Feb. 17, 2015, 12:36 a.m., Jiangjie Qin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31021/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2015, 12:36 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1951 > https://issues.apache.org/jira/browse/KAFKA-1951 > > > Repository: kafka > > > Description > ------- > > Addressed Gwen's comment. > > > Diffs > ----- > > core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala > d1e7c434e77859d746b8dc68dd5d5a3740425e79 > > Diff: https://reviews.apache.org/r/31021/diff/ > > > Testing > ------- > > > Thanks, > > Jiangjie Qin > >
