[ https://issues.apache.org/jira/browse/KAFKA-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14332423#comment-14332423 ]
ASF GitHub Bot commented on KAFKA-1621: --------------------------------------- GitHub user rekhajoshm opened a pull request: https://github.com/apache/kafka/pull/46 KAFKA-1621 : Standardize --messages option KAFKA-1621: Standardize --messages option in perf scripts You can merge this pull request into a Git repository by running: $ git pull https://github.com/rekhajoshm/kafka KAFKA-1621 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/46.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #46 ---- commit d123f48f85604c765b464d6b9d5cee4b3ec0de25 Author: Joshi <rekhajo...@gmail.com> Date: 2015-02-22T23:21:55Z KAFKA-1621 : Standardize --messages option ---- > Standardize --messages option in perf scripts > --------------------------------------------- > > Key: KAFKA-1621 > URL: https://issues.apache.org/jira/browse/KAFKA-1621 > Project: Kafka > Issue Type: Bug > Affects Versions: 0.8.1.1 > Reporter: Jay Kreps > Labels: newbie > > This option is specified in PerfConfig and is used by the producer, consumer > and simple consumer perf commands. The docstring on the argument does not > list it as required but the producer performance test requires it--others > don't. > We should standardize this so that either all the commands require the option > and it is marked as required in the docstring or none of them list it as > required. -- This message was sent by Atlassian JIRA (v6.3.4#6332)