-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28769/
-----------------------------------------------------------
(Updated Feb. 27, 2015, 4:31 a.m.)
Review request for kafka.
Changes
-------
Fixed per review feedback.
Bugs: KAFKA-1809
https://issues.apache.org/jira/browse/KAFKA-1809
Repository: kafka
Description
-------
changed topicmetadata to include brokerendpoints and fixed few unit tests
fixing systest and support for binding to default address
fixed system tests
fix default address binding and ipv6 support
fix some issues regarding endpoint parsing. Also, larger segments for systest
make the validation much faster
added link to security wiki in doc
fixing unit test after rename of ProtocolType to SecurityProtocol
Following Joe's advice, added security protocol enum on client side, and
modified protocol to use ID instead of string.
validate producer config against enum
add a second protocol for testing and modify SocketServerTests to check on
multi-ports
Reverted the metadata request changes and removed the explicit security
protocol argument. Instead the socketserver will determine the protocol based
on the port and add this to the request
bump version for UpdateMetadataRequest and added support for rolling upgrades
with new config
following tests - fixed LeaderAndISR protocol and ZK registration for backward
compatibility
cleaned up some changes that were actually not necessary. hopefully making this
patch slightly easier to review
undoing some changes that don't belong here
bring back config lost in cleanup
fixes neccessary for an all non-plaintext cluster to work
minor modifications following comments by Jun
added missing license
formatting
clean up imports
cleaned up V2 to not include host+port field. Using use.new.protocol flag to
decide which version to serialize
change endpoints collection in Broker to Map[protocol, endpoint], mostly to be
clear that we intend to have one endpoint per protocol
validate that listeners and advertised listeners have unique ports and protocols
support legacy configs
some fixes following rebase
Reverted to backward compatible zk registration, changed use.new.protocol to
support multiple versions and few minor fixes
fixing some issues after rebase
modified inter.broker.protocol config to start with security per feedback
rebasing on trunk again
Diffs (updated)
-----
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
122375c
clients/src/main/java/org/apache/kafka/common/protocol/ApiVersion.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/common/protocol/SecurityProtocol.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/common/utils/Utils.java 69530c1
clients/src/test/java/org/apache/kafka/common/utils/UtilsTest.java 4c2ea34
config/server.properties 1614260
core/src/main/scala/kafka/admin/AdminUtils.scala b700110
core/src/main/scala/kafka/admin/TopicCommand.scala f400b71
core/src/main/scala/kafka/api/ConsumerMetadataResponse.scala 24aaf95
core/src/main/scala/kafka/api/LeaderAndIsrRequest.scala 4ff7e8f
core/src/main/scala/kafka/api/TopicMetadata.scala 0190076
core/src/main/scala/kafka/api/TopicMetadataResponse.scala 92ac4e6
core/src/main/scala/kafka/api/UpdateMetadataRequest.scala 530982e
core/src/main/scala/kafka/client/ClientUtils.scala ebba87f
core/src/main/scala/kafka/cluster/Broker.scala 0060add
core/src/main/scala/kafka/cluster/BrokerEndPoint.scala PRE-CREATION
core/src/main/scala/kafka/cluster/EndPoint.scala PRE-CREATION
core/src/main/scala/kafka/cluster/SecurityProtocol.scala PRE-CREATION
core/src/main/scala/kafka/common/BrokerEndPointNotAvailableException.scala
PRE-CREATION
core/src/main/scala/kafka/consumer/ConsumerConfig.scala 9ebbee6
core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala b9e2bea
core/src/main/scala/kafka/consumer/ConsumerFetcherThread.scala ee6139c
core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 5487259
core/src/main/scala/kafka/controller/ControllerChannelManager.scala c582191
core/src/main/scala/kafka/controller/KafkaController.scala e9b4dc6
core/src/main/scala/kafka/javaapi/ConsumerMetadataResponse.scala d281bb3
core/src/main/scala/kafka/javaapi/TopicMetadata.scala f384e04
core/src/main/scala/kafka/network/RequestChannel.scala 7b1db3d
core/src/main/scala/kafka/network/SocketServer.scala 76ce41a
core/src/main/scala/kafka/producer/ProducerPool.scala 43df70b
core/src/main/scala/kafka/server/AbstractFetcherManager.scala 20c00cb
core/src/main/scala/kafka/server/AbstractFetcherThread.scala 8c281d4
core/src/main/scala/kafka/server/KafkaApis.scala 703886a
core/src/main/scala/kafka/server/KafkaConfig.scala 14bf321
core/src/main/scala/kafka/server/KafkaHealthcheck.scala 7907987
core/src/main/scala/kafka/server/KafkaServer.scala 426e522
core/src/main/scala/kafka/server/MetadataCache.scala 4c70aa7
core/src/main/scala/kafka/server/ReplicaFetcherManager.scala 351dbba
core/src/main/scala/kafka/server/ReplicaFetcherThread.scala 6879e73
core/src/main/scala/kafka/server/ReplicaManager.scala 586cf4c
core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala d1e7c43
core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala ba6ddd7
core/src/main/scala/kafka/tools/SimpleConsumerShell.scala b4f903b
core/src/main/scala/kafka/tools/UpdateOffsetsInZK.scala 111c9a8
core/src/main/scala/kafka/utils/Utils.scala 738c1af
core/src/main/scala/kafka/utils/ZkUtils.scala 8a2fb2d
core/src/test/scala/integration/kafka/api/ConsumerTest.scala 2802a39
core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala
ba48a63
core/src/test/scala/integration/kafka/api/ProducerSendTest.scala b15237b
core/src/test/scala/other/kafka/TestOffsetManager.scala a106379
core/src/test/scala/unit/kafka/KafkaConfigTest.scala 4d36b8b
core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala 1bf2667
core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala
fba852a
core/src/test/scala/unit/kafka/cluster/BrokerTest.scala PRE-CREATION
core/src/test/scala/unit/kafka/consumer/ConsumerIteratorTest.scala c0355cc
core/src/test/scala/unit/kafka/integration/FetcherTest.scala 25845ab
core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala
dc0512b
core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 35dc071
core/src/test/scala/unit/kafka/log/LogTest.scala c2dd8eb
core/src/test/scala/unit/kafka/network/SocketServerTest.scala 0af23ab
core/src/test/scala/unit/kafka/producer/AsyncProducerTest.scala 1db6ac3
core/src/test/scala/unit/kafka/producer/SyncProducerTest.scala d60d8e0
core/src/test/scala/unit/kafka/server/AdvertiseBrokerTest.scala f0c4a56
core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala 82dce80
core/src/test/scala/unit/kafka/server/LeaderElectionTest.scala c2ba07c
core/src/test/scala/unit/kafka/server/LogOffsetTest.scala c06ee75
core/src/test/scala/unit/kafka/utils/TestUtils.scala 21d0ed2
system_test/replication_testsuite/testcase_1/testcase_1_properties.json
0c6d7a3
system_test/utils/kafka_system_test_utils.py 41d511c
Diff: https://reviews.apache.org/r/28769/diff/
Testing
-------
Thanks,
Gwen Shapira
