> On March 3, 2015, 5:43 p.m., Mayuresh Gharat wrote: > > core/src/main/scala/kafka/log/LogCleaner.scala, line 413 > > <https://reviews.apache.org/r/31306/diff/3/?file=878588#file878588line413> > > > > This will mean that if there are unkeyed messages we will neglect them > > and not throw an exception right? > > So we are aloowing unkeyed messages to go through comapction.
Unkeyed messages will be rejected up front (as demonstrated in the unit tests). However, if you change a topic to be compacted (from non-compacted) and it already has unkeyed messages then those will just be ignored (i.e., deleted). - Joel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31306/#review74986 ----------------------------------------------------------- On Feb. 26, 2015, 6:54 p.m., Joel Koshy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31306/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2015, 6:54 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1755 > https://issues.apache.org/jira/browse/KAFKA-1755 > > > Repository: kafka > > > Description > ------- > > KAFKA-1755 v2 > > > re-enable test > > > Incorporate Guozhang's comments > > > Diffs > ----- > > core/src/main/scala/kafka/log/Log.scala > 846023bb98d0fa0603016466360c97071ac935ea > core/src/main/scala/kafka/log/LogCleaner.scala > f8e7cd5fabce78c248a9027c4bb374a792508675 > core/src/main/scala/kafka/log/LogCleanerManager.scala > fd87d90597981c867a9b23731fca3b555bf85b7f > core/src/main/scala/kafka/message/ByteBufferMessageSet.scala > f46ad5cbbbad77d8d1f490d1f8aac97858da9b06 > core/src/main/scala/kafka/server/OffsetManager.scala > 83d52643028c5628057dc0aa29819becfda61fdb > core/src/test/scala/unit/kafka/log/CleanerTest.scala > d10e4f4ccbca5e50d81a243d3ab30cc7314b7fef > core/src/test/scala/unit/kafka/log/LogTest.scala > c2dd8eb69da8c0982a0dd20231c6f8bd58eb623e > core/src/test/scala/unit/kafka/message/ByteBufferMessageSetTest.scala > 73a26377eb63ab9989698e0491049434f032cba2 > > Diff: https://reviews.apache.org/r/31306/diff/ > > > Testing > ------- > > > Thanks, > > Joel Koshy > >
